Bug 4159 - relace [+] and [-] in add remove filter et.al. with something clearer
Summary: relace [+] and [-] in add remove filter et.al. with something clearer
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
Depends on:
Blocks: 3399
  Show dependency treegraph
Reported: 2007-03-06 21:57 UTC by Andrew Cagney
Modified: 2007-03-20 15:27 UTC (History)
0 users

See Also:
Last reconfirmed:


Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2007-03-06 21:57:43 UTC
The intent of the [+] and [-] buttons in the "filters" and "actions" buttons
isn't clear.  For instance:

- why does the first line have a [-]

suggest looking at alternative ways of handling this, such as a mail-tools
filter rules.
Comment 1 Sami Wagiaalla 2007-03-20 15:27:02 UTC
The first line has a [-] because clicking that button while it will not remove
the row it will remove the filter it represents from the observer. It will also
clear the selection boxes and the arguments Entry.

This patch also changes it so that the button is grayed out once it has removed
the filters, and cleared the feilds.

This is exactly what is done in Thunderbuird to edit filters.

2007-03-20  Sami Wagiaalla  <swagiaal@redhat.com>

	* ObserverItemRow.java : [-] Button now disables itself when there is only
	one row is left and the represented filter has been removed from the
	underlying Observer. Fix for bz 4159.