Bug 2145 - run xmllint over the glade files
Summary: run xmllint over the glade files
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P1 normal
Target Milestone: ---
Assignee: Adam Jocksch
URL:
Keywords:
Depends on: 1999
Blocks: 1632 1633 2235
  Show dependency treegraph
 
Reported: 2006-01-12 16:43 UTC by Andrew Cagney
Modified: 2006-02-10 15:56 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2006-01-12 16:43:18 UTC
(along with any other sanity checks -- such as ensuring that it doesn't refer to
gnome)
Comment 1 Andrew Cagney 2006-02-08 16:26:17 UTC
Here's how Makefile.rules was modified to add an additional ECJ check:

# When ECJ is available, use it as an extra lint pass.  GCJ has the
# habit of silently compiling invalid Java code (garbage in, garbage out),
# fortunatly ECJ rejects it.
if HAVE_ECJ
all-local: ecj/checked
endif
ecj/checked: files.list
        rm -rf ecj
        mkdir -p ecj
        $(ECJ) \
                -d ecj \
                -warn:+semicolon \
                -sourcepath $(SOURCEPATH) \
                -classpath $(CLASSPATH) \
                @$(top_builddir)/files.list \
                2>&1 | tee $@.log
        if test -s $@.log ; \
        then rm $@.log ; false ; \
        fi
        rm -f $@.log
        touch $@
.PHONY: clean-ecj-dir
clean-local: clean-ecj-dir
clean-ecj-dir:
        rm -rf ecj

of course for glade files, this would be easier.  No need to worry about
HAVE_ECJ; instead a simplier:
glade.checked:
          for f in x $(glade_DATA) ; do \
                   test "$$f" = x && continue ; \
          ...
would work
Comment 2 Adam Jocksch 2006-02-10 15:56:14 UTC
This has been added to Makefile.rules in common/ and committed