This is the mail archive of the xconq7@sources.redhat.com mailing list for the Xconq project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Wed, 6 Aug 2003, Erik Sigra wrote: > * Make sure that the name is not too long for the buffer. (But does the rest > of xconq always check such things?) No. But, my personal opinion is that these things should be checked for, even if it means either truncating strings or dynamically allocating memory to accomodate them. Xconq is quite admirable in that it tries to do a lot with pre-allocated buffers, but my admiration ends where segfaults begin. I added a patch about a month ago that did address some of these buffer overflows (by using dynamic allocation), and I didn't get any negative feedback about it, __FWIW. Regards, Eric
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |