This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[RFC PATCH -tip 1/2] trace: kprobes: Show sum of probe/retprobe nmissed count
- From: Masami Hiramatsu <mhiramat at kernel dot org>
- To: Steven Rostedt <rostedt at goodmis dot org>, Ingo Molnar <mingo at kernel dot org>
- Cc: Frederic Weisbecker <fweisbec at gmail dot com>, systemtap at sourceware dot org, linux-kernel at vger dot kernel dot org, Alban Crequy <alban dot crequy at gmail dot com>, Alban Crequy <alban at kinvolk dot io>, Thomas Gleixner <tglx at linutronix dot de>, Ingo Molnar <mingo at redhat dot com>, "H . Peter Anvin" <hpa at zytor dot com>, Ananth N Mavinakayanahalli <ananth at linux dot vnet dot ibm dot com>, Anil S Keshavamurthy <anil dot s dot keshavamurthy at intel dot com>, "David S . Miller" <davem at davemloft dot net>
- Date: Tue, 22 Aug 2017 00:41:11 +0900
- Subject: [RFC PATCH -tip 1/2] trace: kprobes: Show sum of probe/retprobe nmissed count
- Authentication-results: sourceware.org; auth=none
- Authentication-results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
- Authentication-results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat at kernel dot org
- Dmarc-filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C3452170C
- References: <150332999488.7343.4502723000922707699.stgit@devbox>
Show sum of probe and retprobe nmissed count in
kprobe_profile, since retprobe can be missed even
if the kprobe itself succeeeded.
This explains user why their return probe didn't hit
sometimes.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Tested-by: Alban Crequy <alban@kinvolk.io>
---
kernel/trace/trace_kprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index c9b5aa10fbf9..fe1bd541216c 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -928,7 +928,7 @@ static int probes_profile_seq_show(struct seq_file *m, void *v)
seq_printf(m, " %-44s %15lu %15lu\n",
trace_event_name(&tk->tp.call),
trace_kprobe_nhit(tk),
- tk->rp.kp.nmissed);
+ tk->rp.kp.nmissed + tk->rp.nmissed);
return 0;
}