This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug runtime/21726] on rawhide, the backtrace.exp test case causes a kernel panic


https://sourceware.org/bugzilla/show_bug.cgi?id=21726

--- Comment #3 from Mark Wielaard <mark at klomp dot org> ---
The actual crash is in:

static int _stp_valid_pc_addr(unsigned long addr, struct task_struct *tsk)
{
        /* Just a simple check of whether the the address can be accessed
           as a user space address. Zero is always bad. */

/* FIXME for s390x PR13350. */
#if defined (__s390__) || defined (__s390x__)
       return addr != 0L;
#else
        int ok;
        mm_segment_t oldfs = get_fs();
        set_fs(USER_DS);
        ok = access_ok(VERIFY_READ, (long *) (intptr_t) addr, sizeof(long));
        set_fs(oldfs);
        return addr != 0L && tsk != NULL ? ok : ! ok;
#endif
}

Changing the first #if 1 || ... so that the check simply becomes teturn addr !=
0L makes the crash go away.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]