[Bug runtime/20042] New: on rawhide, tracepoint handlers have a changed function signature

["dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=20042

            Bug ID: 20042
           Summary: on rawhide, tracepoint handlers have a changed
                    function signature
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: dsmith at redhat dot com
  Target Milestone: ---

On rawhide (4.6.0-0.rc5.git3.1.fc25.x86_64), it looks like the tracepoint
interface has changed, causing compilation errors with scripts that use
tracepoints:

====
# stap -v ../src/testsuite/systemtap.base/tracepoints.stp 
Pass 1: parsed user script and 113 library scripts using
241388virt/38096res/7572shr/30784data kb, in 200usr/40sys/232real ms.
Pass 2: analyzed script: 1925 probes, 1 function, 0 embeds, 1 global using
260332virt/57992res/8624shr/49728data kb, in 82200usr/19540sys/53882real ms.
Pass 3: translated to C into
"/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_src.c" using
261868virt/59564res/8688shr/51264data kb, in 550usr/70sys/616real ms.
In file included from
/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.c:8:0:
/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.c: In
function âregister_tracepoint_probe_1212â:
/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.c:27:42:
error: passing argument 1 of âcheck_trace_callback_type_cpuhp_enterâ from
incompatible pointer type [-Werror=incompatible-pointer-types]
   return STP_TRACE_REGISTER(cpuhp_enter, enter_tracepoint_probe_1212);
                                          ^
/usr/local/share/systemtap/runtime/linux/stp_tracepoint.h:45:38: note: in
definition of macro âSTP_TRACE_REGISTERâ
     check_trace_callback_type_##name(fn);   \
                                      ^~
In file included from ./arch/x86/include/asm/kvm_host.h:17:0,
                 from include/linux/kvm_host.h:36,
                 from
/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.c:4:
include/linux/tracepoint.h:218:2: note: expected âvoid (*)(void *, unsigned
int,  int,  int,  int (*)(unsigned int))â but argument is of type âvoid
(*)(void *, unsigned int,  int,  int,  void *)â
  check_trace_callback_type_##name(void (*cb)(data_proto)) \
  ^
include/linux/tracepoint.h:348:2: note: in expansion of macro â__DECLARE_TRACEâ
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
  ^~~~~~~~~~~~~~~
include/linux/tracepoint.h:484:2: note: in expansion of macro âDECLARE_TRACEâ
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^~~~~~~~~~~~~
include/trace/events/cpuhp.h:9:1: note: in expansion of macro âTRACE_EVENTâ
 TRACE_EVENT(cpuhp_enter,
 ^~~~~~~~~~~
In file included from
/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.c:8:0:
/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.c: In
function âunregister_tracepoint_probe_1212â:
/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.c:30:44:
error: passing argument 1 of âcheck_trace_callback_type_cpuhp_enterâ from
incompatible pointer type [-Werror=incompatible-pointer-types]
   (void) STP_TRACE_UNREGISTER(cpuhp_enter, enter_tracepoint_probe_1212);
                                            ^
/usr/local/share/systemtap/runtime/linux/stp_tracepoint.h:49:38: note: in
definition of macro âSTP_TRACE_UNREGISTERâ
     check_trace_callback_type_##name(fn);   \
                                      ^~
In file included from ./arch/x86/include/asm/kvm_host.h:17:0,
                 from include/linux/kvm_host.h:36,
                 from
/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.c:4:
include/linux/tracepoint.h:218:2: note: expected âvoid (*)(void *, unsigned
int,  int,  int,  int (*)(unsigned int))â but argument is of type âvoid
(*)(void *, unsigned int,  int,  int,  void *)â
  check_trace_callback_type_##name(void (*cb)(data_proto)) \
  ^
include/linux/tracepoint.h:348:2: note: in expansion of macro â__DECLARE_TRACEâ
  __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args),  \
  ^~~~~~~~~~~~~~~
include/linux/tracepoint.h:484:2: note: in expansion of macro âDECLARE_TRACEâ
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^~~~~~~~~~~~~
include/trace/events/cpuhp.h:9:1: note: in expansion of macro âTRACE_EVENTâ
 TRACE_EVENT(cpuhp_enter,
 ^~~~~~~~~~~
cc1: all warnings being treated as errors
scripts/Makefile.build:291: recipe for target
'/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.o' failed
make[1]: ***
[/tmp/staphWDwgS/stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740_aux_30.o] Error
1
make[1]: *** Waiting for unfinished jobs....
Makefile:1432: recipe for target '_module_/tmp/staphWDwgS' failed
make: *** [_module_/tmp/staphWDwgS] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compiled C into "stap_3b2a8c89bb4805ee669dd1b436014d8c_1186740.ko" in
47480usr/10000sys/38954real ms.
Pass 4: compilation failed.  [man error::pass4]
====

-- 
You are receiving this mail because:
You are the assignee for the bug.