This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug runtime/19940] page_cache_release() missing from the latest rawhide kernel


https://sourceware.org/bugzilla/show_bug.cgi?id=19940

--- Comment #1 from David Smith <dsmith at redhat dot com> ---
Looks like this was caused by the following kernel changes:

====
commit 1fa64f198b9f8d6ec0f7aec7c18dc94684391140                                 
Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>                    
Date:   Fri Apr 1 15:29:49 2016 +0300                                           

    mm: drop PAGE_CACHE_* and page_cache_{get,release} definition               

    All users gone.  We can remove these macros.                                
====

====
commit 09cbfeaf1a5a67bfb3201e0c83c810cecb2efa5a                                 
Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>                    
Date:   Fri Apr 1 15:29:47 2016 +0300                                           

    mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros         

    PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time       
    ago with promise that one day it will be possible to implement page         
    cache with bigger chunks than PAGE_SIZE.                                    

    This promise never materialized.  And unlikely will.                        

    We have many places where PAGE_CACHE_SIZE assumed to be equal to            
    PAGE_SIZE.  And it's constant source of confusion on whether                
    PAGE_CACHE_* or PAGE_* constant should be used in a particular case,        
    especially on the border between fs and mm.                                 

    Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much        
    breakage to be doable.                                                      

    Let's stop pretending that pages in page cache are special.  They are       
    not.                                                                        

    The changes are pretty straight-forward:                                    

     - <foo> << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;                       

     - <foo> >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> <foo>;                       

     - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};      

     - page_cache_get() -> get_page();                                          

     - page_cache_release() -> put_page();                                      

    This patch contains automated changes generated with coccinelle using       
    script below.  For some reason, coccinelle doesn't patch header files.      
    I've called spatch for them manually.                                       

    The only adjustment after coccinelle is revert of changes to                
    PAGE_CAHCE_ALIGN definition: we are going to drop it later.                 

    There are few places in the code where coccinelle didn't reach.  I'll       
    fix them manually in a separate patch.  Comments and documentation also     
    will be addressed with the separate patch.                                  
====

-- 
You are receiving this mail because:
You are the assignee for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]