This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug runtime/19799] deleting from array of aggregate unreliable


https://sourceware.org/bugzilla/show_bug.cgi?id=19799

--- Comment #3 from David Smith <dsmith at redhat dot com> ---
Created attachment 9081
  --> https://sourceware.org/bugzilla/attachment.cgi?id=9081&action=edit
simple patch

Here's the simple version of a patch to fix this bug. It deletes the value from
every cpu's map, then deletes the value from the aggregate map.

I've tested it with the test script I uploaded earlier, and it fixes the
problem there. I'm going to more fully test it and see how it goes.

I'm seeing some skipped probes with using this patch, so I'll try to work on a
more sophisticated version that only computes the hash once. I doubt it will
make much difference when the map indices are integers, but it could make a
difference when the map indices are strings.

I also need to write up a test case for this issue so it remains fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]