This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: Prelinking on ARM with Debug Link
- From: Mark Wielaard <mjw at redhat dot com>
- To: Torsten Polle <Torsten dot Polle at gmx dot de>
- Cc: systemtap at sourceware dot org
- Date: Tue, 23 Feb 2016 17:46:51 +0100
- Subject: Re: Prelinking on ARM with Debug Link
- Authentication-results: sourceware.org; auth=none
- References: <4BCA4243-B16B-436F-9D53-41C551492A51 at gmx dot de> <6E47DD0A-0515-45C6-86A1-4669A8182663 at gmx dot de> <1455121041 dot 7606 dot 104 dot camel at redhat dot com> <3855EE25-54F2-47FB-88A8-FF1EC3963C06 at gmx dot de> <1455136517 dot 7606 dot 107 dot camel at redhat dot com> <trinity-fb9190d9-ee29-4674-8066-0251f630d69b-1455187752264 at 3capp-gmx-bs27> <1455617312 dot 9915 dot 50 dot camel at redhat dot com> <1FF3B18B-EEA4-4A00-8E4F-3B7977E0111C at gmx dot de> <1455812509 dot 7770 dot 4 dot camel at redhat dot com> <23DAF1AA-DD74-4B03-8290-A4CB49F10D14 at gmx dot de>
On Mon, 2016-02-22 at 22:45 +0100, Torsten Polle wrote:
> the principle idea of your patch works. But I had to rewrite it to
> really work in my environment. Could you please have a look at my
> proposal? Would something like that be acceptable?
Could you give an example of what didn't work?
You cast both debug_frame_off and dwbias to uint32_t before
substracting. Is that really necessary/correct? Both are Dwarf_Addrs
which are always uint64_t. And we care about the difference here.
> I would like to double check in my environment if we could fall back to the hex notation again.
Isn't it simpler and consistent to just always use decimal in this case?
There should at least be a comment why we use a different notation for
elf32 vs elf64 targets.
Thanks,
Mark