This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v3] Add new case for stress test
- From: David Smith <dsmith at redhat dot com>
- To: Zhou Wenjian <zhouwj-fnst at cn dot fujitsu dot com>, systemtap at sourceware dot org
- Date: Thu, 14 Jan 2016 15:41:33 -0600
- Subject: Re: [PATCH v3] Add new case for stress test
- Authentication-results: sourceware.org; auth=none
- References: <1452672114-32384-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com>
On 01/13/2016 02:01 AM, Zhou Wenjian wrote:
> * testsuite/systemtap.stress/parallel_exec.exp: New test case
I've checked this in as commit 3453e68. Note that I ended up making
several changes:
- I got a consistent failure from the test when the test was run the
first time (before the script was cached). I solved this by 2 methods.
(1) I added a timeout value to the loop that increments 'num_sum'; and
(2) I moved running the script once to get the number of output lines by
1 script invocation before the loop. This allows the loop to always used
the cached script module.
- I changed 'grep \[open|close\]' to 'grep {\(open\|close\)}'. An
expression using brackets - '[' and ']' - is a list of characters to
look for. So, your regexp would have matched any combination of those
letters.
- I added your comments about the purpose behind the ending '$num *
$process_num != $num_sum' logic.
Thanks for the test.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)