This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/4] add case for probe timer
- From: David Smith <dsmith at redhat dot com>
- To: Zhou, Wenjian/åæå <zhouwj-fnst at cn dot fujitsu dot com>, "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: systemtap at sourceware dot org
- Date: Mon, 30 Nov 2015 15:48:57 -0600
- Subject: Re: [PATCH 1/4] add case for probe timer
- Authentication-results: sourceware.org; auth=none
- References: <1447406704-14585-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com> <5656C888 dot 3080503 at cn dot fujitsu dot com>
On 11/26/2015 02:53 AM, "Zhou, Wenjian/åæå" wrote:
> Hello Frank and David,
>
> I try to send essential cases, but I can't make sure all of the cases
> are needed.
> So I need your help. If you have time, you can tell me why the cases have
> no sense, or you can just let me know which are meaningless.
> Both will help me a lot.
I can't really speak for Frank, but I took a further look at the
testcases. Here's what I found:
PATCH 1/4 (timer testcase): Checked in
PATCH 2/4 (conditional compile): This testcase looks like it tests the
same things as testsuite/systemtap.base/preprocessor.exp. If you feel
like your testcase found something that one doesn't, we can add new
subtests to preprocessor.exp.
PATCH 3/4 (add cases for var definition): Checked in.
PATCH 4/4 (add cases for var type): This one looks very similar to
testsuite/semko/typedefinition.stp. Once again if you feel like your
testcase found something this one doesn't, we can add new subtests to
typedefinition.exp.
Thanks again for the tests.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)