This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] add testcases for variables scope
- From: David Smith <dsmith at redhat dot com>
- To: Zhou Wenjian <zhouwj-fnst at cn dot fujitsu dot com>, systemtap at sourceware dot org
- Date: Thu, 5 Nov 2015 10:50:13 -0600
- Subject: Re: [PATCH] add testcases for variables scope
- Authentication-results: sourceware.org; auth=none
- References: <1446712067-24880-1-git-send-email-zhouwj-fnst at cn dot fujitsu dot com>
On 11/05/2015 02:27 AM, Zhou Wenjian wrote:
> * testsuite/systemtap.base/var_scope.exp: New test case.
> * testsuite/systemtap.base/var_scope.stp: New test file.
Thanks for the new test case, I've checked it in:
<https://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commitdiff;h=09b9b8b1d782630f4ccf7c129c6526cc45ed731a;hp=f104f853a637ee3a197d6094f362e45ed64f4d27>
Note that I made one small tweak. You had 2 end probes, the first
printing "systemtap ending probe" and the second printing the
success/fail message. For end probes without any sequence numbers, I
don't believe we guarantee any execution order. So, I combined the two
probes. The other option would have been to add sequence numbers, i.e.:
probe end(0) ...
probe end(1) ...
Thanks again.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)