[Bug testsuite/18971] process_by_pid.exp issues

["jistone at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18971

Josh Stone <jistone at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jistone at redhat dot com

--- Comment #1 from Josh Stone <jistone at redhat dot com> ---
(Readers beware, there's also a proc_by_pid.exp, vs. this process_by_pid.exp)

(In reply to Martin Cermak from comment #0)
> 1) TC fails since in dyninst mode -c or -x is needed (stapdyn: WARNING:
> process probes require a target (-c or -x)) (PR17352).

This test is trying to be sure that with multiple copies of the program
running, only the right process(PID) will match.  When you add -x, that's kind
of cheating.  Maybe it's better to just KFAIL referencing that bug.

> 2) TC fails since stap_run() gets unexpected warnings similar to "stapdyn:
> WARNING: Couldn't instrument the function containing" ...

I'm uneasy about a global filter on this -- it's a good sign that the test is
about to fail if we're missing some probes.  But in some cases like this we
have broad wildcards, and may not care that a few are missing.

> 3) TC fails since plt probes aren't being hit in dyninst mode (PR17359).
> 
> Attached patch might solve 1) and 2). For 3), the fail might possibly be
> marked as KFAIL?

Yeah, that's another good reason to KFAIL.

-- 
You are receiving this mail because:
You are the assignee for the bug.