This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug translator/17906] The test to restrict nearest probes to ABSOLUTE and RELATIVE causing unprivileged_probes.exp tests with wildcards to fail


https://sourceware.org/bugzilla/show_bug.cgi?id=17906

Jonathan Lebon <jlebon at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jlebon at redhat dot com

--- Comment #1 from Jonathan Lebon <jlebon at redhat dot com> ---
Hey Will,

Thanks for reporting this, looks like I didn't catch it when I made the change.
If I remember correctly, the reasoning was that it didn't make sense to have
wildcards with .nearest. E.g. .statement("foo@file.c:15").nearest and
.statement("foo@file.c+3").nearest have clear meanings (use the nearest
probe-able addrs to these linenos).

On the other hand, with .statement("foo@file.c:*").nearest, since "*" already
means "expand to all possible probe-able linenos", adding a .nearest makes no
difference since they will all already be valid linenos. In that sense, I guess
we could allow the syntax without really changing behaviour. At the time, I
leaned on the stricter interpretation of "this is redundant so the user
probably meant something else".

-- 
You are receiving this mail because:
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]