This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] filename in tapset nfs.proc.open and nfs.proc.release
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: David Smith <dsmith at redhat dot com>
- Cc: hai wu <haiwu dot us at gmail dot com>, systemtap at sourceware dot org
- Date: Mon, 15 Dec 2014 15:34:07 -0500
- Subject: Re: [PATCH] filename in tapset nfs.proc.open and nfs.proc.release
- Authentication-results: sourceware.org; auth=none
- References: <CAJ1=nZcYtxopEs-XGj-Cs89dfzA2LF8oScnc_b+JE1zysg1T=Q at mail dot gmail dot com> <548F3F8D dot 8000900 at redhat dot com>
David Smith <dsmith@redhat.com> writes:
> [...] Thanks for the patch, but I don't think this is really what
> we want here. Here's why: [...]
The full pathname is almost certainly more useful in the many probes
where __file_filename() is currently used (I recall receiving some
complaints about that long ago, just not getting to the bottom), and
the cost is not -that- high. But point taken, some might not want to
pay that.
One way to have it both ways is to extend each these probe aliases
(only some dozen or so) to define a new context variable like
'fullpath' sibling of 'file*name'. It would fully resolve the path
name. (I'd certainly switch argstr over to print that instead of the
last component.)
- FChE