This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v9 20/26] kprobes: Support blacklist functions in module
- From: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- To: Ingo Molnar <mingo at kernel dot org>, Jason Baron <jbaron at akamai dot com>
- Cc: linux-kernel at vger dot kernel dot org, Rusty Russell <rusty at rustcorp dot com dot au>, Andi Kleen <andi at firstfloor dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, x86 at kernel dot org, Steven Rostedt <rostedt at goodmis dot org>, fche at redhat dot com, mingo at redhat dot com, Rob Landley <rob at landley dot net>, "H. Peter Anvin" <hpa at zytor dot com>, Thomas Gleixner <tglx at linutronix dot de>, "David S. Miller" <davem at davemloft dot net>, systemtap at sourceware dot org
- Date: Fri, 25 Apr 2014 19:55:53 +0900
- Subject: Re: [PATCH -tip v9 20/26] kprobes: Support blacklist functions in module
- Authentication-results: sourceware.org; auth=none
- References: <20140417081636 dot 26341 dot 87858 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140417081856 dot 26341 dot 53535 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140424085601 dot GA7768 at gmail dot com> <5358F458 dot 1030300 at hitachi dot com> <20140425081951 dot GA24829 at gmail dot com> <535A34F1 dot 3000106 at hitachi dot com>
(2014/04/25 19:12), Masami Hiramatsu wrote:
> (2014/04/25 17:19), Ingo Molnar wrote:
>>
>> * Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>>
>>> (2014/04/24 17:56), Ingo Molnar wrote:
>>>>> diff --git a/include/linux/module.h b/include/linux/module.h
>>>>> index f520a76..2fdb673 100644
>>>>> --- a/include/linux/module.h
>>>>> +++ b/include/linux/module.h
>>>>> @@ -16,6 +16,7 @@
>>>>> #include <linux/kobject.h>
>>>>> #include <linux/moduleparam.h>
>>>>> #include <linux/jump_label.h>
>>>>> +#include <linux/kprobes.h>
>>>>
>>>> This include breaks the x86 build:
>>>>
>>>> CC arch/x86/kernel/jump_label.o
>>>> In file included from arch/x86/kernel/jump_label.c:14:0:
>>>> /fast/mingo/tip/arch/x86/include/asm/kprobes.h:35:12: error: conflicting types for âkprobe_opcode_t' typedef u8 kprobe_opcode_t;
>>>> [...]
>>>
>>> Hmm, this error seems very odd... and I don't see
>>
>> Needs 'make allnoconfig' or some similar .config combination.
>
> Ah, OK. I could reproduce it. And as far as I can see, this is jump_label's bug.
> jump_label.c includes asm/kprobes.h directly, but that header is for internal use.
> It has to include linux/kprobes.h instead. Moreover, it doesn't need kprobes.h anymore.
Oops, arch/x86/kernel/ftrace.c also has same problem. At this point, I'll just
remove unneeded #include from module.h, which can avoid both.
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com