This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v8 17/26] notifier: Use NOKPROBE_SYMBOL macro in notifier
- From: Steven Rostedt <rostedt at goodmis dot org>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: linux-kernel at vger dot kernel dot org, Ingo Molnar <mingo at kernel dot org>, Andi Kleen <andi at firstfloor dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, x86 at kernel dot org, fche at redhat dot com, mingo at redhat dot com, systemtap at sourceware dot org, "H. Peter Anvin" <hpa at zytor dot com>, Thomas Gleixner <tglx at linutronix dot de>
- Date: Tue, 25 Mar 2014 06:58:14 -0400 (EDT)
- Subject: Re: [PATCH -tip v8 17/26] notifier: Use NOKPROBE_SYMBOL macro in notifier
- Authentication-results: sourceware.org; auth=none
- References: <20140305115843 dot 22766 dot 8355 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140305120042 dot 22766 dot 48538 dot stgit at ltc230 dot yrl dot intra dot hitachi dot co dot jp> <20140324161227 dot 6b93b5af at gandalf dot local dot home> <5331593E dot 7060803 at hitachi dot com>
On Tue, 25 Mar 2014, Masami Hiramatsu wrote:
Thanks! I guess since notify_die() is called from any kind of fault,
which may be happen inside ftrace too.
I see it was added by commit 36dcd67ae, which was when we tried to keep
ftrace from tracing nmi functions. It is safe to do so now, so that
notrace can be removed. I'll make a note of that and remove it later :-)
-- Steve