This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug tapsets/16472] long chain of nested function calls consumes a lot of empty whitespace due to thread_indent() function


https://sourceware.org/bugzilla/show_bug.cgi?id=16472

fahadaliarshad at gmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7365|0                           |1
        is obsolete|                            |

--- Comment #7 from fahadaliarshad at gmail dot com ---
Created attachment 7439
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7439&action=edit
patch (ver 2) for adding call-depth functionality

Based on your comment #3, I have factored out _generic_indent_depth:long (idx,
delta) and based my thread_indent_depth:long (delta:long) on it, which returns
a number now. Also, I tested the post-increment/pre-decrement behavior to keep
+1/-1 pairs (call/return) consistent.

Below is a sample output from one of my applications. Note that column two
represent the function call-depth. The field next to calls/returns(=>/<=) is
the called/returned-from function-name.

1393423651768235 0 => import
1393423651768554 1 => main
1393423651768567 1 <= main
1393423651768579 0 <= import
1393423651768594 0 => loadClass
1393423651768602 1 => findFile
1393423651768612 1 <= findFile
1393423651770492 1 => main
1393423651770509 1 <= main
1393423651770517 0 <= loadClass
1393423651770528 0 => getApplication
1393423651770544 1 => loadClass
1393423651770551 2 => findFile
1393423651770562 2 <= findFile

Please do let me know if this is fine for merging or is there anything else you
suggest to add. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]