This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: Re: [RFC PATCH v1 0/2] perf: Support for SDT markers
- From: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- To: Hemant Kumar <hkshaw at linux dot vnet dot ibm dot com>
- Cc: Namhyung Kim <namhyung at kernel dot org>, linux-kernel at vger dot kernel dot org, srikar at linux dot vnet dot ibm dot com, peterz at infradead dot org, oleg at redhat dot com, hegdevasant at linux dot vnet dot ibm dot com, mingo at redhat dot com, anton at redhat dot com, systemtap at sourceware dot org, aravinda at linux dot vnet dot ibm dot com, penberg at iki dot fi
- Date: Wed, 26 Feb 2014 18:42:22 +0900
- Subject: Re: Re: [RFC PATCH v1 0/2] perf: Support for SDT markers
- Authentication-results: sourceware.org; auth=none
- References: <20140224090833 dot 7998 dot 5416 dot stgit at hemant-fedora> <530C821D dot 7000704 at hitachi dot com> <530CBD53 dot 9010605 at linux dot vnet dot ibm dot com> <87ha7muw14 dot fsf at sejong dot aot dot lge dot com> <530DADEB dot 4090709 at linux dot vnet dot ibm dot com>
(2014/02/26 18:03), Hemant Kumar wrote:
> On 02/26/2014 01:48 PM, Namhyung Kim wrote:
>> Hi Masami and Hemant,
>>
>> On Tue, 25 Feb 2014 21:27:07 +0530, Hemant Kumar wrote:
>>> On 02/25/2014 05:14 PM, Masami Hiramatsu wrote:
>>>> (2014/02/24 18:14), Hemant Kumar wrote:
>>>>> First, scan the binaries using :
>>>>> # perf list sdt --scan
>>>>>
>>>>> Creating a cache of SDT markers...
>>>>> perf sdt cache created!
>>>>> Use : "perf list sdt"
>>>>> to see the SDT markers
>>>> Hmm, in that case, I think you'd better introduce perf-sdt for scanning.
>>>> e.g.
>>>>
>>>> # perf sdt --scan app
>>> Hmm, this seems a better idea :)
>>>
>>>> then you can add app to sdt cache, without app,
>>>>
>>>> # perf sdt --scan
>>>>
>>>> will just scans all binaries on the PATH and the libraries which listed
>>>> by `ldconfig --print-caceh`
>> What should be done with the new perf sdt command? If it's only
>> intended to list the markers, I'd just suggest to add "perf list sdt" as
>> this patch did.
No, here what I said is, the "perf sdt" is only for managing SDT cache
as like as "perf buildid-cache". Thus, "perf sdt-cache" might be better.
BTW, the SDT markers can be changed if the application is updated.
To ensure the correctness of SDT markers, we should store buildid in the
cache file and check it when listing and using them.
> If we display the SDT markers along with the other events in perf list,
> then I think we can go with
> perf list sdt. I am not too sure though! :)
>
> For me, the main issue was that the markers are not events. They become
> events after
> we place them in the uprobe_events file just like functions. But we use
> `perf list` to
> display all the "events" available on a system. Isn't it?
As I said, if perf accepts -e "%app:sdt" option, showing SDT events as
fixed events does not matter, since it is transparent to users. :)
Thank you,
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com