This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
[Bug tapsets/16472] long chain of nested function calls consumes a lot of empty whitespace due to thread_indent() function
- From: "jistone at redhat dot com" <sourceware-bugzilla at sourceware dot org>
- To: systemtap at sourceware dot org
- Date: Wed, 19 Feb 2014 18:52:13 +0000
- Subject: [Bug tapsets/16472] long chain of nested function calls consumes a lot of empty whitespace due to thread_indent() function
- Auto-submitted: auto-generated
- References: <bug-16472-6586 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=16472
--- Comment #3 from Josh Stone <jistone at redhat dot com> ---
On further reflection, I'm probably complicated your request too much. I think
it would be fine to simply factor out a _generic_indent_depth(idx,delta) and
base your thread_indent_depth:long(delta:long) on that - but note I'm
suggesting to return the number directly. That's more flexible, and the caller
can easily make that a string if desired. We should have a global
indent_depth() too.
Note this should also maintain the post-increment/pre-decrement behavior, which
is desirable to keep +1/-1 pairs (like call/return) reported at the same level.
Your original patch always reported the resulting indentation, which means a
call would report greater indentation than its return.
--
You are receiving this mail because:
You are the assignee for the bug.