This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip 1/3] [CLEANUP] perf-probe: Expand given path to absolute path
- From: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- To: Namhyung Kim <namhyung at kernel dot org>
- Cc: Ingo Molnar <mingo at kernel dot org>, Arnaldo Carvalho de Melo <acme at ghostprotocols dot net>, Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>, David Ahern <dsahern at gmail dot com>, lkml <linux-kernel at vger dot kernel dot org>, "Steven Rostedt (Red Hat)" <rostedt at goodmis dot org>, Oleg Nesterov <oleg at redhat dot com>, "David A. Long" <dave dot long at linaro dot org>, systemtap at sourceware dot org, yrl dot pp-manager dot tt at hitachi dot com
- Date: Mon, 23 Dec 2013 19:46:17 +0900
- Subject: Re: [PATCH -tip 1/3] [CLEANUP] perf-probe: Expand given path to absolute path
- Authentication-results: sourceware.org; auth=none
- References: <20131220100255 dot 7169 dot 19384 dot stgit at kbuild-fedora dot novalocal> <20131220100257 dot 7169 dot 60537 dot stgit at kbuild-fedora dot novalocal> <871u14drbf dot fsf at sejong dot aot dot lge dot com>
(2013/12/23 15:17), Namhyung Kim wrote:
> Hi Masami,
>
> On Fri, 20 Dec 2013 10:02:57 +0000, Masami Hiramatsu wrote:
>> Expand given path to absolute path in option parser,
>> except for a module name. Instead of expanding it later,
>> this get the absolute path in early stage.
>>
>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>> ---
>> tools/perf/builtin-probe.c | 9 +++++++++
>> tools/perf/util/probe-event.c | 11 ++---------
>> 2 files changed, 11 insertions(+), 9 deletions(-)
>>
>> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
>> index 6ea9e85..b40d064 100644
>> --- a/tools/perf/builtin-probe.c
>> +++ b/tools/perf/builtin-probe.c
>> @@ -180,6 +180,15 @@ static int opt_set_target(const struct option *opt, const char *str,
>> else
>> return ret;
>>
>> + /* Expand given path to absolute path, except for modulename */
>> + if (params.uprobes || strchr(str, '/')) {
>> + str = realpath(str, NULL);
>> + if (!str) {
>> + pr_warning("Failed to find the path of %s.\n",
>> + str);
>
> It won't print the path since the str already was overwritten to NULL.
Oops ...
>> + return ret;
>> + }
>> + }
>> params.target = str;
>
> It now points either a dynamically allocated string or not..
Ah, right. OK, I'll use strdup for such case.
Thank you!
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com