This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -tip v5 12/18] ftrace/kprobes: Use NOKPROBE_SYMBOL macro in ftrace
- From: Steven Rostedt <rostedt at goodmis dot org>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: Ingo Molnar <mingo at kernel dot org>, linux-arch at vger dot kernel dot org, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Sandeepa Prabhu <sandeepa dot prabhu at linaro dot org>, Frederic Weisbecker <fweisbec at gmail dot com>, x86 at kernel dot org, lkml <linux-kernel at vger dot kernel dot org>, Ingo Molnar <mingo at redhat dot com>, systemtap at sourceware dot org, "David S. Miller" <davem at davemloft dot net>
- Date: Mon, 9 Dec 2013 12:04:50 -0500
- Subject: Re: [PATCH -tip v5 12/18] ftrace/kprobes: Use NOKPROBE_SYMBOL macro in ftrace
- Authentication-results: sourceware.org; auth=none
- References: <20131209104717 dot 13397 dot 8864 dot stgit at kbuild-fedora dot novalocal> <20131209104746 dot 13397 dot 22146 dot stgit at kbuild-fedora dot novalocal>
On Mon, 09 Dec 2013 10:47:46 +0000
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> --- a/kernel/trace/trace_probe.h
> +++ b/kernel/trace/trace_probe.h
> @@ -124,8 +124,8 @@ struct probe_arg {
> const struct fetch_type *type; /* Type of this argument */
> };
>
> -static inline __kprobes void call_fetch(struct fetch_param *fprm,
> - struct pt_regs *regs, void *dest)
> +static inline void call_fetch(struct fetch_param *fprm,
> + struct pt_regs *regs, void *dest)
> {
> return fprm->fn(regs, fprm->data, dest);
> }
>
Is this OK to be probed? I've had cases where a header "static inline"
was not always inlined. Unless you have "__always_inline" this is not
guaranteed to be inlined.
As for the rest of the patch:
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve