This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Curly brace outside macro conditional typo
- From: Miroslav Franc <mfranc at redhat dot com>
- To: systemtap at sourceware dot org
- Date: Mon, 11 Nov 2013 00:24:16 +0100
- Subject: Curly brace outside macro conditional typo
- Authentication-results: sourceware.org; auth=none
Hi. Commit 7acb3e34 introduced some bad syntax. The outer if statement use curly braces to create a block, however the ending curly brace ended up outside macro conditional.
diff --git a/runtime/linux/uprobes-common.c b/runtime/linux/uprobes-common.c
index 2dc6f14..ed4df86 100644
--- a/runtime/linux/uprobes-common.c
+++ b/runtime/linux/uprobes-common.c
@@ -128,11 +128,11 @@ static int stap_uprobe_change_plus (struct task_struct *tsk, unsigned long reloc
/* NB: duplicates common_entryfn_epilogue,
but then this is not a probe entry fn epilogue. */
#ifndef STAP_SUPPRESS_HANDLER_ERRORS
- if (unlikely (atomic_inc_return (skipped_count()) > MAXSKIPPED)) {
- if (unlikely (pseudo_atomic_cmpxchg(session_state(), STAP_SESSION_RUNNING, STAP_SESSION_ERROR) == STAP_SESSION_RUNNING))
+ if (unlikely (atomic_inc_return (skipped_count()) > MAXSKIPPED)) {
+ if (unlikely (pseudo_atomic_cmpxchg(session_state(), STAP_SESSION_RUNNING, STAP_SESSION_ERROR) == STAP_SESSION_RUNNING))
_stp_error ("Skipped too many probes, check MAXSKIPPED or try again with stap -t for more details.");
-#endif
}
+#endif
}
} /* close iteration over stap_uprobe_spec[] */
return 0; /* XXX: or rc? */
--
Miroslav Franc, QE, Tool Chain mfranc@redhat.com
"During smoke testing you are waiting for magic smoke to appear
whereas during sanity testing you are praying for your sanity."