This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug translator/13974] sdt.h is incompatible with clang


https://sourceware.org/bugzilla/show_bug.cgi?id=13974

--- Comment #4 from Josh Stone <jistone at redhat dot com> ---
(In reply to Josh Stone from comment #3)
> The second gave us a hint that led me to use %note instead of "note", with
> %%-quoting as needed for operand expansion.  This is pushed in commit
> a31190f5.

I'm actually going to revert this.  The difficulty of '%' is that it must be
escaped for asm() blocks that have operands, but must not be escaped in asm()
blocks without operands, nor for pure ASM source files.  But we have a
SDT_PROBE_ASM construct available for others to use in their own asm(), where
we have no idea if escaping is needed.  It turns out glibc uses this, and we
broke their build on Fedora rawhide due to bad %-escaping.

We can't use @note because GAS says that's a comment on ARM, so we're left back
at "note" being the most straightforward.  I'll revert the change, but at least
now we have some documented justification for the chosen syntax.

Besides, LLVM finished up 17270 with support for the "note" syntax, so anyone
interested in SDT there can use an LLVM snapshot or wait for their next
release.

-- 
You are receiving this mail because:
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]