This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] autotools: search.h
- From: Adrian M Negreanu <groleo at gmail dot com>
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: SystemTap <systemtap at sourceware dot org>, Adrian Marius Negreanu <adrian dot m dot negreanu at intel dot com>
- Date: Thu, 28 Mar 2013 10:49:29 +0200
- Subject: Re: [PATCH] autotools: search.h
- References: <1364407084-22932-1-git-send-email-groleo at gmail dot com> <y0mli98b74i dot fsf at fche dot csb>
On Thu, Mar 28, 2013 at 4:17 AM, Frank Ch. Eigler <fche@redhat.com> wrote:
> groleo@gmail.com writes:
>
>> From: Adrian Marius Negreanu <adrian.m.negreanu@intel.com>
>
>> +/* Define to 1 if you have the <search.h> header file. */
>> +#undef HAVE_SEARCH_H
>> [...]
>
> Wow, none of that in bionic?
Unfortunately , no.
Also, there's no wordexp.h. I see some TODO's mentioning tokenize()
but that's not applicable
in all cases where wordexp() is used.
getline() is missing too but there's fgetln() that i use as a replacement.
>
>> @@ -661,6 +664,7 @@ int stp_main_loop(void)
>> if (verbose) { /* don't eliminate duplicates */
>> eprintf("%.*s", (int) nb, recvbuf.payload.data);
>> break;
>> +#ifdef HAVE_SEARCH_H
>> } else { /* eliminate duplicates */
>> static void *seen = 0;
>> static unsigned seen_count = 0;
>> @@ -706,6 +710,7 @@ int stp_main_loop(void)
>> } else { /* old message */
>> free (dupstr);
>> }
>> +#endif
>> } /* duplicate elimination */
>
> It'd be a shame to lose WARNING: duplicate elimination altogether, but
> I wouldn't be keen on reinventing the tfind/tsearch wheels either.
>
>
> - FChE
--
Regards!
http://groleo.wordpress.com