This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH v4 -tip 0/3] x86/kprobes: bugfixes and split optprobes
- From: Ingo Molnar <mingo at elte dot hu>
- To: Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>
- Cc: linux-kernel at vger dot kernel dot org, Thomas Gleixner <tglx at linutronix dot de>, "H. Peter Anvin" <hpa at zytor dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, yrl dot pp-manager dot tt at hitachi dot com, systemtap at sourceware dot org, anderson at redhat dot com
- Date: Tue, 6 Mar 2012 10:10:25 +0100
- Subject: Re: [PATCH v4 -tip 0/3] x86/kprobes: bugfixes and split optprobes
- References: <20120305133200.5982.45827.stgit@localhost.localdomain>
* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> Hi,
>
> Here are the patches for fixing bugs in kprobes on x86.
>
> - Both bugs are related to the optprobe.
> - First bugfix is optprobe to recover instructions when
> thoes are modified with jump.
> - Second bugfix is kprobes to recover it too.
>
> This series also includes a patch which split optprobes
> parts out from kprobes x86 implementation.
>
> Ingo, I've added the splitting patch according your
> advice :)
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (3):
> x86/kprobes: Split out optprobe related code to kprobes-opt.c
> [BUGFIX] x86/kprobes: Fix a bug which can modify kernel code
> [BUGFIX] x86/kprobes: Fix to recover instructions on optimized path
>
>
> arch/x86/kernel/Makefile | 1
> arch/x86/kernel/kprobes-common.h | 106 ++++++
> arch/x86/kernel/kprobes-opt.c | 516 +++++++++++++++++++++++++++++++
> arch/x86/kernel/kprobes.c | 633 ++++----------------------------------
> 4 files changed, 684 insertions(+), 572 deletions(-)
> create mode 100644 arch/x86/kernel/kprobes-common.h
> create mode 100644 arch/x86/kernel/kprobes-opt.c
Thanks, this looks very nice. I've applied them to tip:perf/core
and will push them out later today, assuming there are no test
failures.
Thanks,
Ingo