This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug kprobes/13108] kprobing some paravirt stuff seems unsafe


http://sourceware.org/bugzilla/show_bug.cgi?id=13108

Mark Wielaard <mjw at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Mark Wielaard <mjw at redhat dot com> 2011-09-05 22:07:56 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > The patch in comment #1 doesn't seem to prevent setting a probe on
> > kernel.function("clts"), so it is wrong, haven't figured out why yet though.
> 
> Ugh -- I think you've uncovered another bug, that blfile probably shouldn't be
> ^-anchored at the start.

Wow, you are right! After some experimentation it seems only include/asm/*.h
files that get selected by "full path". So I fixed it with:

commit 44a7e76ab8cd9b9942b8d8a72d065269cd637c4a
Author: Mark Wielaard <mjw@redhat.com>
Date:   Mon Sep 5 23:37:11 2011 +0200

    PR13112 (and PR13108) blacklist probing function from include/asm .h files.

    dwflpp.cxx (build_blacklist): all include/asm .h blfile patterns might
    need "full path" so prefix those with '.*'
    Add new XFAIL semok.exp inb_blacklisted.stp testcase.

Plus a patch to explicitly list the paravirt ops functions with:

commit 1b43894364dec075d13636b3c78c786da73fc8ad
Author: Mark Wielaard <mjw@redhat.com>
Date:   Mon Sep 5 23:44:53 2011 +0200

    PR13108 blacklist probing paravirt ops from paravirt.c or paravirt.h.

See also the follow up commit 4a507d for PR13112.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]