This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC] [PATCH 2.6.37-rc5-tip 5/20] 5: Uprobes: register/unregister probes.
- From: Peter Zijlstra <peterz at infradead dot org>
- To: Srikar Dronamraju <srikar at linux dot vnet dot ibm dot com>
- Cc: Ingo Molnar <mingo at elte dot hu>, Steven Rostedt <rostedt at goodmis dot org>, Linux-mm <linux-mm at kvack dot org>, Arnaldo Carvalho de Melo <acme at infradead dot org>, Linus Torvalds <torvalds at linux-foundation dot org>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Christoph Hellwig <hch at infradead dot org>, Masami Hiramatsu <masami dot hiramatsu dot pt at hitachi dot com>, Oleg Nesterov <oleg at redhat dot com>, Andrew Morton <akpm at linux-foundation dot org>, SystemTap <systemtap at sources dot redhat dot com>, Jim Keniston <jkenisto at linux dot vnet dot ibm dot com>, Frederic Weisbecker <fweisbec at gmail dot com>, Andi Kleen <andi at firstfloor dot org>, LKML <linux-kernel at vger dot kernel dot org>, "Paul E. McKenney" <paulmck at linux dot vnet dot ibm dot com>
- Date: Thu, 27 Jan 2011 11:41:17 +0100
- Subject: Re: [RFC] [PATCH 2.6.37-rc5-tip 5/20] 5: Uprobes: register/unregister probes.
- References: <20101216095817.23751.76989.sendpatchset@localhost6.localdomain6> <1295957744.28776.722.camel@laptop> <20110126075558.GB19725@linux.vnet.ibm.com> <1296036708.28776.1138.camel@laptop> <20110126153036.GN19725@linux.vnet.ibm.com> <1296056756.28776.1247.camel@laptop> <20110126165645.GP19725@linux.vnet.ibm.com> <1296061949.28776.1343.camel@laptop> <20110127100157.GS19725@linux.vnet.ibm.com> <1296123817.15234.57.camel@laptop> <20110127102527.GT19725@linux.vnet.ibm.com>
On Thu, 2011-01-27 at 15:55 +0530, Srikar Dronamraju wrote:
>
>
> If its not at the exact same location, then our third validation of
> checking that (vaddr == vma->vm_start + uprobe->offset) should fail
> right?
>
> Also should it be (vaddr == uprobe->offset + vma->vm_start -
> vma->pgoff << PAGE_SHIFT) ?
Yeah, although I just realized that ->offset should be a u64, since
pgoff is a unsigned long, we can have files up to 44 bit (assuming the
page-size is 12bits).
But yes, this matches the validation I mentioned.