This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug translator/11091] vta-test.exp failure loc2c u_const declaration duplication with multiple pieces


------- Additional Comments From mjw at redhat dot com  2010-01-13 11:50 -------
commit 9fa29c5277f3e3f4525ff3335a2cbc2b518c2010
Author: Mark Wielaard <mjw@redhat.com>
Date:   Thu Jan 7 17:54:28 2010 +0100

    Fix multi-piece constant failure in vta-test.exp on 32bit systems.
    
    Commit 73b5e9 "Make sure loc2c declare_noncontig_union for different locs
    don't overlap", wasn't complete. It only took into account having a piece
    becuase of a noncontiguous loc and a constant loc together. But pieces can
    be nested deeper (newer gcc outputs multiple constant locations for one
    piece on 32bit systems). This patch keeps track of the piece declaration
    depth. Another approach could have been to have each sub-piece in its own
    local scope, but keeping track of the depth and naming the temporary unions
    distinct fitted the current code better. It currently only supports a depth
    of 10. An error will be emitted if a location construct needs more than 10
    pieces to be assembled.
    
    * loc2c.c (declare_noncontig_union): Take depth argument. Always use the
      same name for the union (u_pieces<depth>).
      (translate_base_fetch): Take depth argument. Use it to calculate union
      names.
      (translate_base_store): Likewise.
      (c_translate_fetch): Pass in depth zero.
      (c_translate_store): Likewise.
      (c_translate_pointer): Likewise.
      (c_translate_pointer_store): Likewise.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=11091

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]