This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Update SCSI tapset


Andre Detsch <adetsch@br.ibm.com> writes:

> This patch updates the scsi.stp tapset, as long as the correspondent testcase.
> [...] 

> Changes are:
>   * Inclusion of two new probes: scsi.set_state and scsi.ioexecute
>   * device_state and data_direction values are now available in string
>     form, reflecting the enum identificator, instead of its integer id
>   * Minor fix in scsi.iodispatching documentation: "req_bufflen" is actually
>     called "request_bufflen"
>   * Testcase now prints not only the values, but also the name of the fields
>   * Some housekeeping, such as white space and tabulation fixes
> [...]

Looks good to me.  Is the existing scsi-related example (iostat-scsi)
a sufficient showcase of this tapset?

- FChE


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]