This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH] Update SCSI tapset
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Andre Detsch <adetsch at br dot ibm dot com>
- Cc: systemtap at sources dot redhat dot com
- Date: Fri, 18 Dec 2009 12:18:53 -0500
- Subject: Re: [PATCH] Update SCSI tapset
- References: <200912022012.53460.adetsch@br.ibm.com>
Andre Detsch <adetsch@br.ibm.com> writes:
> This patch updates the scsi.stp tapset, as long as the correspondent testcase.
> [...]
> Changes are:
> * Inclusion of two new probes: scsi.set_state and scsi.ioexecute
> * device_state and data_direction values are now available in string
> form, reflecting the enum identificator, instead of its integer id
> * Minor fix in scsi.iodispatching documentation: "req_bufflen" is actually
> called "request_bufflen"
> * Testcase now prints not only the values, but also the name of the fields
> * Some housekeeping, such as white space and tabulation fixes
> [...]
Looks good to me. Is the existing scsi-related example (iostat-scsi)
a sufficient showcase of this tapset?
- FChE