This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH -next 0/3] x86 insn decoder test updates (Re: linux-next: Tree for October 29 (x86 posttest))
- From: Ingo Molnar <mingo at elte dot hu>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: linux-next at vger dot kernel dot org, Stephen Rothwell <sfr at canb dot auug dot org dot au>, Randy Dunlap <rdunlap at xenotime dot net>, Jim Keniston <jkenisto at us dot ibm dot com>, "H. Peter Anvin" <hpa at zytor dot com>, lkml <linux-kernel at vger dot kernel dot org>, systemtap <systemtap at sources dot redhat dot com>, DLE <dle-develop at lists dot sourceforge dot net>
- Date: Tue, 17 Nov 2009 07:13:52 +0100
- Subject: Re: [PATCH -next 0/3] x86 insn decoder test updates (Re: linux-next: Tree for October 29 (x86 posttest))
- References: <20091116230611.5250.86656.stgit@harusame>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Here are the patches which update x86 instruction decoder build-time
> test. As Stephen reported on linux-next, sometimes objdump decodes bad
> instructions as normal. This will cause a false positive result on x86
> insn decoder test. This patches update the test as below;
>
> - Show more information with V=1
> - Show in which symbol the difference places.
> - Just warning instead of build failure.
yes, -tip testing was showing such build bugs too:
Error: ffffffff8104aae3: c5 83 3d 49 80 ee lds 0xffffffffee80493d(%rbx),%eax
Error: objdump says 6 bytes, but insn_get_length() says 3 (attr:0)
it happens with older tools, such as binutils-2.17. Modern binutils
(2.19) is fine.
We dont want to remove the build error: it helped us fix a number of
real bugs in the decoder - instead please try to create a make based
workaround based on binutils, to not run the test with binutils older
than 2.19 or so.
Thanks,
Ingo