Re: Tapset for probing IRQs, workqueues, etc

[Josh Stone <jistone at redhat dot com>]

On 10/29/2009 08:55 AM, Prerna Saxena wrote:
> Hi ,
> Posting a new version of the IRQ tapset.
> 
> On 10/27/2009 01:42 AM, David Smith wrote:
> 
>>
>> I took a short look at your tapset.  In general, it looks fine.
>>
>> I do have one question.  You added a function called '_irqflags_str' to
>> aux_syscalls.stp, but I couldn't find a caller of that new function in
>> your tapset.  It looks like you might have meant to call it for the
>> 'flags' variables in irq_handler.entry and irq_handler.exit.
> 
> I have not included the flags string on purpose for this probe point, 
> cos I think that one might need to look up the flags in specific 
> debugging scenarios only. It would not be required in most commonly used 
> cases, such as the attached example. However, I have documented the 
> function both inline in the tapset documentation and also in the man 
> pages, so that a script developer wanting to display a formatted string 
> can call the function when needed.

It wouldn't hurt to have the tapset provide it as something like
flags_str.  That makes it more obvious for the user, and our optimizer
should remove it automatically if it's not used.


Josh