This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug uprobes/10595] uprobe probes causes selinux failures


------- Additional Comments From jkenisto at us dot ibm dot com  2009-09-04 18:08 -------
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #5)
> > > Created an attachment (id=4170)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4170&action=view)
> > > ssol-vma-selinux patch using shmem_file_setup
> > 
> > At this point
> >        if (addr & ~PAGE_MASK) {
> > addr will be undefined if shmem_file_setup() returned NULL.
> 
> addr would be 0 if !file, since earlier in the function we have:
> 
>         if ((addr = find_old_ssol_vma()) != 0)
>                 return addr;

You're right, it'd be 0.  But with above test, addr==0 would look like success.

> 
> > Yes, runtime/uprobes/uprobes.c and ubp_xol.c (?) in the ubp-based uprobes bits.
> >  Thanks, mjw.  Srikar, are you going to take it from here?
> 
> I found fche's utrace-ext.git repo, is that where those are now? I can certainly
> build that and supply a patch for it. Which branch should it be against?
> utrace-uprobes or utrace-gdbstub-uprobes? Does that uprobes kernel module
> version work against systemtap git?

Sorry, I haven't been keeping up with that code base except via code reviews.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10595

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]