This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 3/3] PR 10081: improve error message for verifying build-id
- From: Roland McGrath <roland at redhat dot com>
- To: Wenji Huang <wenji dot huang at oracle dot com>
- Cc: systemtap at sourceware dot org
- Date: Fri, 24 Apr 2009 13:23:26 -0700 (PDT)
- Subject: Re: [PATCH 3/3] PR 10081: improve error message for verifying build-id
- References: <1240593874-31186-1-git-send-email-wenji.huang@oracle.com>
> + if (strncmp(m->build_id_bits, (unsigned char*) notes_addr, m->build_id_len)) {
They are not strings. This should be memcmp.
Thanks,
Roland