This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/1] Add new TCP and IP functions
- From: Breno Leitao <leitao at linux dot vnet dot ibm dot com>
- To: Josh Stone <jistone at redhat dot com>
- Cc: systemtap at sources dot redhat dot com, Andrà Detsch <adetsch at br dot ibm dot com>
- Date: Mon, 13 Apr 2009 16:01:52 -0300
- Subject: Re: [PATCH 1/1] Add new TCP and IP functions
- References: <49DD1306.9060003@linux.vnet.ibm.com> <49E38929.8020802@redhat.com>
Josh
Thanks for the good review
Josh Stone wrote:
>> +/* returns TCP URG flag for a given sk_buff structure */
>> +function __tcp_skb_urg:long (skb:long){
>> + urg = ntohs(@cast(__get_skb_tcphdr(skb), "tcphdr")->urg) & 32
>> + return urg >> 5
>> +}
>
> Such bit-manipulation shouldn't be needed, but it looks like our
> generated dereference code is not masking out bitfields correctly. I'll
> file a bugzilla on this.
That is right. So, should I wait until it's fixed, or just let it as it is ?