[Bug testsuite/10007] Some SystemTap tests need updates to handle SYSCALL_WRAPPERS

["dsmith at redhat dot com" <sourceware-bugzilla at sourceware dot org>]

------- Additional Comments From dsmith at redhat dot com  2009-03-26 13:56 -------
(In reply to comment #1)
> Created an attachment (id=3848)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=3848&action=view)
> Fix systemtap testsuite to better handle syscalls
> 
> Here is a patch that makes the testsuite to refer to the syscall tapset aliases
> rather than the syscall function names directly. If the patch looks ok, I'll
> check it in.

I took a short look at this patch.  Besides the testsuite changes, it looks like
there is also an actual s390 syscall tapset change in there.

I'm a bit confused by the changes to systemtap.base/stmtvars.exp and
systemtap.base/system_func.stp.  Instead of changing
'kernel.function("sys_open")' to 'syscall.open', you changed it to
'kernel.function("do_sys_open")'.  Why was this done?

Other than those points, I guess I'm a bit worried that syscall tapset bugs are
going to cause lots of (somewhat unrelated) testsuite failures.  But, I don't
see any easier solution to this problem.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10007

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.