This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/2] marker probe: $name support (Re: [RFC] sample test script and tapset for markers)
- From: "Frank Ch. Eigler" <fche at redhat dot com>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: systemtap-ml <systemtap at sources dot redhat dot com>, Hideo AOKI <haoki at redhat dot com>, Takahiro Yasui <tyasui at redhat dot com>
- Date: Fri, 5 Sep 2008 11:44:26 -0400
- Subject: Re: [PATCH 1/2] marker probe: $name support (Re: [RFC] sample test script and tapset for markers)
- References: <48B42A17.1080106@redhat.com> <y0mhc97y59m.fsf@ton.toronto.redhat.com> <48C15108.6010401@redhat.com>
Hi -
On Fri, Sep 05, 2008 at 11:32:24AM -0400, Masami Hiramatsu wrote:
> Here is a patch which add $name variable access from marker probe.
> I added _stp_mark_context structure which contains .name and .format
> strings for passing both of them to marker handler. [...]
That seems unnecessary. You could have added the name/format as
separate fields, and have the embedded-C functions use
CONTEXT->marker_name / marker_format. (Those fields then better be
cleared to zero for other types of probes, and the embedded-C code
better check for that.)
- FChE