This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [RFC] Tracepoint proposal
- From: Alexey Dobriyan <adobriyan at gmail dot com>
- To: Mathieu Desnoyers <mathieu dot desnoyers at polymtl dot ca>
- Cc: Peter Zijlstra <peterz at infradead dot org>, Masami Hiramatsu <mhiramat at redhat dot com>, Steven Rostedt <rostedt at goodmis dot org>, "Frank Ch. Eigler" <fche at redhat dot com>, Ingo Molnar <mingo at elte dot hu>, LKML <linux-kernel at vger dot kernel dot org>, systemtap-ml <systemtap at sources dot redhat dot com>, Hideo AOKI <haoki at redhat dot com>
- Date: Tue, 24 Jun 2008 04:20:10 +0400
- Subject: Re: [RFC] Tracepoint proposal
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=/ZDpHsk0Wt9MIoaXFyI0l+lqrspi4Mt+iesuLeeofSw=; b=J/RfGcFN3ZPi9HvQ6QgA/jUpkwZL9Zi7hjAYsZXQ47wEvFKqIv83TtieqU/r4qkhsq syfr7O+RmCYKoanMq6qvSXP/5rAABukS70tt0U048l0otBYqhEYne+xyxRWK/pf+iGfu co3AP+hzO+ISZA9GrLGb69zpreHfNOi3lv76k=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=aeaF7gPvDUS9u+naLCWJ7fCR1Y8G8g5qhfcedDBdCt1HbA6NRIIamMWfNMsEORhU+8 ljeToNRTdhM5HosvLPljY8xq620q00gxhjD5fPaJQuJXDeUgj6qI5PVLEUyYxRvCbTcl XMiqn436fsyr5Nal+/byxui05/MYD2gc6CxPY=
- References: <485BE2C6.1080901@redhat.com> <20080620174529.GB10943@Krystal> <1213992446.3223.195.camel@lappy.programming.kicks-ass.net> <20080622171135.GA19432@Krystal> <20080622175928.GA5022@martell.zuzino.mipt.ru> <20080622182705.GA23301@Krystal>
On Sun, Jun 22, 2008 at 02:27:05PM -0400, Mathieu Desnoyers wrote:
> * Alexey Dobriyan (adobriyan@gmail.com) wrote:
> > On Sun, Jun 22, 2008 at 01:11:35PM -0400, Mathieu Desnoyers wrote:
> > > Tracepoint proposal
> > >
> > > - Tracepoint infrastructure
> > > - In-kernel users
> > > - Complete typing, verified by the compiler
> > > - Dynamically linked and activated
> > >
> > > - Marker infrastructure
> > > - Exported API to userland
> > > - Basic types only
> > >
> > > - Dynamic vs static
> > > - In-kernel probes are dynamically linked, dynamically activated, connected to
> > > tracepoints. Type verification is done at compile-time. Those in-kernel
> > > probes can be a probe extracting the information to put in a marker or a
> > > specific in-kernel tracer such as ftrace.
> > > - Information sinks (LTTng, SystemTAP) are dynamically connected to the
> > > markers inserted in the probes and are dynamically activated.
> > >
> > > - Near instrumentation site vs in a separate tracer module
> > >
> > > A probe module, only if provided with the kernel tree, could connect to internal
> > > tracing sites. This argues for keeping the tracepoing probes near the
> > > instrumentation site code. However, if a tracer is general purpose and exports
> > > typing information to userspace through some mechanism, it should only export
> > > the "basic type" information and could be therefore shipped outside of the
> > > kernel tree.
> > >
> > > In-kernel probes should be integrated to the kernel tree. They would be close to
> > > the instrumented kernel code and would translate between the in-kernel
> > > instrumentation and the "basic type" exports. Other in-kernel probes could
> > > provide a different output (statistics available through debugfs for instance).
> > > ftrace falls into this category.
> > >
> > > Generic or specialized information "sinks" (LTTng, systemtap) could be connected
> > > to the markers put in tracepoint probes to extract the information to userspace.
> > > They would extract both typing information and the per-tracepoint execution
> > > information to userspace.
> > >
> > > Therefore, the code would look like :
> > >
> > > kernel/sched.c:
> > >
> > > #include "sched-trace.h"
> > >
> > > schedule()
> > > {
> > > ...
> > > trace_sched_switch(prev, next);
> > > ...
> > > }
> >
> > Once this is accepted you're going to add hundreds of such calls to every
> > core subsystem, right?
> >
>
> The LTTng instrumentation has about 125 of such calls. Tests have
> revealed that adding such dormant tracepoints to the kernel often
> increase kernel performances rather than decreasing it (see the ia64
> benchmarks posted on lkml a few weeks ago).
We're not adding this for performance increase, you do realize this?
> The core subsystem maintainers are being involved in the process.
NAK this from proc if you about this.
> Actually, marking up the source code has the interesting effect of
> letting knowledgeable people influence the trace point decisions.
I'd say that maximum source code overhead any tracing facility should be
allowed is "__xxx" annotation at very start of function definition.
Anything beyond should be rejected and there are good reasons for that.