This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: pr 6644 optimizations
- From: "Stone, Joshua I" <joshua dot i dot stone at intel dot com>
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Cc: "systemtap at sources dot redhat dot com" <systemtap at sources dot redhat dot com>
- Date: Thu, 19 Jun 2008 19:33:28 -0700
- Subject: Re: pr 6644 optimizations
- References: <20080619182450.GA18439@redhat.com>
Frank Ch. Eigler wrote:
> Thanks for the pr 6644 code. Could you investigate though whether all
> those new dynamic_cast<>s could be replaced by more properly typed new
> members in the custom visitors?
Sure - I just pushed a changed that eliminated all but one cast.
I could remove the last one with a function like the existing
expression_is_arrayindex(), but IMO that's just a poor man's
dynamic_cast<>.
Josh