This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: Results of systemtap-20080517 snapshot on ppc64
- From: Jim Keniston <jkenisto at us dot ibm dot com>
- To: ananth at in dot ibm dot com
- Cc: Srinivasa DS <srinivasa at in dot ibm dot com>, systemtap at sources dot redhat dot com
- Date: Mon, 19 May 2008 12:10:28 -0700
- Subject: Re: Results of systemtap-20080517 snapshot on ppc64
- References: <48317377.8020302@in.ibm.com> <20080519124943.GC19677@in.ibm.com>
On Mon, 2008-05-19 at 18:19 +0530, Ananth N Mavinakayanahalli wrote:
> On Mon, May 19, 2008 at 06:02:55PM +0530, Srinivasa DS wrote:
> > Attaching results of systemtap-20080517 snapshot on ppc64. I have applied
> > one interim fix(present in bug#6429) and executed the tests.
>
> Looks like there are a higher number of errors compared to the earlier
> tests... probably new features?
>
...
>
> > FAIL: semok/nodwf01.stp
> > FAIL: semok/nodwf02.stp
> > FAIL: semok/nodwf03.stp
> ^^^^^^^^^^
> These are probably related to dwarfless
...
Yup. Please try the attached patch and see if it fixes the dwarfless
failures.
Ananth et al, can you think of any kernel functions (nm type T or t)
where this simple mapping of ".func" to "func" would cause problems?
>
> Ananth
Thanks.
Jim
--- a/tapsets.cxx 2008-05-19 12:02:37.000000000 -0700
+++ b/tapsets.cxx 2008-05-19 12:02:51.000000000 -0700
@@ -4681,6 +4681,11 @@
symbol_table::add_symbol(const char *name, Dwarf_Addr addr,
Dwarf_Addr *high_addr)
{
+#ifdef __powerpc__
+ // Map ".sys_foo" to "sys_foo".
+ if (name[0] == '.')
+ name++;
+#endif
func_info *fi = new func_info();
fi->addr = addr;
fi->name = name;