This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption
- From: Ingo Molnar <mingo at elte dot hu>
- To: Masami Hiramatsu <mhiramat at redhat dot com>
- Cc: Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, Jim Keniston <jkenisto at us dot ibm dot com>, Roland McGrath <roland at redhat dot com>, prasanna at in dot ibm dot com, anil dot s dot keshavamurthy at intel dot com, davem at davemloft dot net, Harvey Harrison <harvey dot harrison at gmail dot com>, systemtap-ml <systemtap at sources dot redhat dot com>, LKML <linux-kernel at vger dot kernel dot org>, Arjan van de Ven <arjan at infradead dot org>
- Date: Wed, 19 Dec 2007 11:20:07 +0100
- Subject: Re: [PATCH 1/2] x86: fix kprobe_handler reenable preemption
- References: <4768555A.3000604@redhat.com> <476890CC.1020100@redhat.com>
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> > - return 1;
> > + ret = 1;
>
> Here, "return 1;" is correct. After single step is done, preemption is
> enabled in post_kprobe_handler().
could you resend the fixed patch? (instead of me fixing it up by hand -
which is error-prone)
also, this seems like .24 material as well - could you send the fix
against -rc5 too?
Ingo