This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]Add a function kernel_string2 for copy non-0-terminated string with fixed length from kernel space at given address.

Hi, Joshua

Thanks for your suggestion. I have changed it to kernel_string_n.
Also, I have tested it on RHEL5(IA64).

I will commit it soon.

Stone, Joshua I wrote:
Cai Fei wrote:
So I added a function kernel_string2 for copy non-0-terminated string
with fixed length from kernel space at given address. Also, the man
paged is updated.

The new function looks fine.  My only suggestion is that a more
meaningful name would be nice.  Maybe kernel_string_n or
kernel_string_max.

Oh, tests would also be nice.

Thanks,

Josh




--
A new email address of FJWAN is launched from Apr.1 2007.
The updated address is: caifei@cn.fujitsu.com
--------------------------------------------------
Cai Fei
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
caifei@cn.fujitsu.com  (å7551-5875)
--------------------------------------------------

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]