Re: error: label 'deref_fault' used but not defined

[Mike Mason <mmlnx at us dot ibm dot com>]

Stone, Joshua I wrote:
> Frank Ch. Eigler wrote:
> > Steve Dickson <steved@4Dicksons.org> writes:
> >
> > > I'm getting an "label 'deref_fault' used but not defined" error when
> > > I try to pulling the __svc_fh() function from the
> > > /usr/share/systemtap/tapset/nfsd.stp file. [...]
> > This was caused by a typo in the __svc_fh embedded-C function.  It
> > must not have been compiled before.  There are others. :-(
>
> Ack -- fuel for Mike's fire... ;)

Yep, thanks for helping prove my point :-)

The simple nfsd test I proposed:

	#! stap -up4
	probe nfsd.*, nfsd.*.*, nfsd.*.*.* {}

uncovers the above mentioned bug and this bug,too:

/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c: In function 
'function_clones_from_clnt':
/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c:20683: 
error: 'struct rpc_clnt' has no member named 'cl_count'
/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c: In function 
'function_tasks_from_clnt':
/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.c:20704: 
error: 'struct rpc_clnt' has no member named 'cl_users'
make[1]: *** 
[/tmp/stapdp9Xov/stap_e5010bda224ed441f0885c3021876241_231538.o] Error 1

Those bugs are fixable.  If this test had also reported 'unfixable' bugs, 
how could I have written it such that it only reported the fixable bugs?

Mike

> > "Why do my eyes hurt?" - Neo
> > "You've never used them before." - Morpheus
>
> Nice.
>
>
> Josh