This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Trace code and documentation

From: David Wilder <dwilder at us dot ibm dot com>
To: Sam Ravnborg <sam at ravnborg dot org>
Cc: linux-kernel at vger dot kernel dot org, SystemTAP <systemtap at sources dot redhat dot com>, akpm at linux-foundation dot org
Date: Fri, 14 Sep 2007 21:49:31 -0700
Subject: Re: [PATCH 1/2] Trace code and documentation
References: <46E9CB14.7060000@us.ibm.com> <20070914175027.GA3642@uranus.ravnborg.org>

Sam Ravnborg wrote:

Hi David.
A random comment to the code.
Several of the struct file_operations are not declared static as
they should be.
Btw. it looks good from a coding style point-of-view.

About the name what about ktrace??

Sam

Thanks for the comment. I sure don't want to change the name a forth time, can we live with "trace"?

Follow-Ups:
- Re: [PATCH 1/2] Trace code and documentation
  - From: Sam Ravnborg

References:
- [PATCH 1/2] Trace code and documentation
  - From: David Wilder
- Re: [PATCH 1/2] Trace code and documentation
  - From: Sam Ravnborg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]