This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [patch] Fix bug of syscall.lseek's offset
- From: fche at redhat dot com (Frank Ch. Eigler)
- To: Lai Jiangshan <laijs at cn dot fujitsu dot com>
- Cc: systemtap at sourceware dot org
- Date: Tue, 04 Sep 2007 11:22:33 -0400
- Subject: Re: [patch] Fix bug of syscall.lseek's offset
- References: <46CA9241.2010008@cn.fujitsu.com> <46DD08A8.10604@cn.fujitsu.com>
Lai Jiangshan <laijs@cn.fujitsu.com> writes:
> How about the following patch? Is there any problem?
> [...]
>> probe syscall.lseek = kernel.function("sys_lseek") {
>> [...]
>> - offset = __int32($offset)
>> + offset = $offset
This looks good to me, as long as it tests fine on some 32-bit hosts.
We had some $variable width/signedness problems that were fixed a few
months ago in bug #3331. It may have fixed the need for the __int32
kludge too.
- FChE