This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: Proposal for small addition to testsuite output
Wenji Huang <wenji.huang@oracle.com> writes:
> According to Kris' proposal, I made a small change to systemtap.exp. [...]
> +proc get_system_info {} {
This part is OK
> +get_system_info
> +set logname "$logname\nHost: $Host\nSnapshot: $Snapshot\nDistro: $Distro\n"
I suspect that changing "logname" like this is suspect. How about
simply computing and printing the new fields in print_systemtap_version,
which is already defined in testsuite/lib/systemtap.exp. They should be
changed to log the data too, not just print it to the screen.
- FChE