This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: BZ#2421 - removing duplicate probe handlers

From: "Frank Ch. Eigler" <fche at redhat dot com>
To: David Smith <dsmith at redhat dot com>
Cc: systemtap at sources dot redhat dot com
Date: Tue, 1 Aug 2006 18:53:29 -0400
Subject: Re: BZ#2421 - removing duplicate probe handlers
References: <1153430594.9668.57.camel@dhcp-2.hsv.redhat.com> <1153494928.11557.24.camel@dhcp-2.hsv.redhat.com> <20060721160146.GB4437@redhat.com> <1153509205.11557.48.camel@dhcp-2.hsv.redhat.com> <1154457399.30303.36.camel@dhcp-2.hsv.redhat.com>

Hi -

> I made a stab at removing duplicate functions.  I cheated and just
> hashed the args/body of functions to do comparisons.  All duplicate
> functions are redirected to the first copy found.  A patch is
> attached.  [...]

It may be straightforward to have a general hashing_visitor that
computes an overall hash value into member variable.  It should
certainly mix in a hash of the function body, especially in the case
of an embedded-C function such as those generated for $target
variables.

- FChE

References:
- Re: BZ#2421 - removing duplicate probe handlers
  - From: Frank Ch. Eigler
- Re: BZ#2421 - removing duplicate probe handlers
  - From: David Smith
- Re: BZ#2421 - removing duplicate probe handlers
  - From: David Smith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]