This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH]kprobe booster for IA64
- From: Masami Hiramatsu <hiramatu at sdl dot hitachi dot co dot jp>
- To: Masami Hiramatsu <hiramatu at sdl dot hitachi dot co dot jp>
- Cc: "bibo,mao" <bibo dot mao at intel dot com>, "Keshavamurthy, Anil S" <anil dot s dot keshavamurthy at intel dot com>, Ananth N Mavinakayanahalli <ananth at in dot ibm dot com>, SystemTAP <systemtap at sources dot redhat dot com>, Yumiko Sugita <sugita at sdl dot hitachi dot co dot jp>, Satoshi Oshima <soshima at redhat dot com>, Hideo Aoki <haoki at redhat dot com>, Prasanna S Panchamukhi <prasanna at in dot ibm dot com>, Jim Keniston <jkenisto at us dot ibm dot com>
- Date: Mon, 26 Jun 2006 19:33:14 +0900
- Subject: Re: [PATCH]kprobe booster for IA64
- References: <4485223C.8090109@sdl.hitachi.co.jp> <44868B03.70108@intel.com> <448834B6.1010002@sdl.hitachi.co.jp> <4488E275.1020304@intel.com> <4490F42D.5010301@sdl.hitachi.co.jp>
Hi,
Masami Hiramatsu wrote:
> /*
> + * In this function, we check whether the target bundle is possible
> + * to modify IP and whether it may occur an exception.
> + */
> +static __always_inline int can_boost(uint template, unsigned long addr,
> + uint slot)
> +{
> + addr &= ~0xFULL;
> + do {
> + if (search_exception_tables(addr + (++slot))) /* we must check the next slot. */
I mixed up the trap with other faults. We must check the fault
probability from the target slot. So I must change it to ;
> + if (search_exception_tables(addr + (slot++)))
Thanks,
--
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: hiramatu@sdl.hitachi.co.jp