This is the mail archive of the
systemtap@sourceware.org
mailing list for the systemtap project.
Re: [PATCH]Systemtap IA64 Runtime support
- From: Roland McGrath <roland at redhat dot com>
- To: Keshavamurthy Anil S <anil dot s dot keshavamurthy at intel dot com>
- Cc: systemtap at sources dot redhat dot com, bibo dot mao at intel dot com,yanmin dot zhang at intel dot com, rohit dot seth at intel dot com
- Date: Thu, 27 Oct 2005 13:53:43 -0700 (PDT)
- Subject: Re: [PATCH]Systemtap IA64 Runtime support
Please clean up your patches so they don't touch unrelated lines with
random whitespace changes.
Don't use unadorned "inline", that defines globals. For inlines in a
header for the kernel, use "static inline".
For the ia64 register accessors, is it really advantageous to inline those?
Perhaps the functions should be in the runtime proper rather than inlined
by the macros.
Thanks,
Roland