This is the mail archive of the systemtap@sourceware.org mailing list for the systemtap project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]Systemtap IA64 Runtime support


Please clean up your patches so they don't touch unrelated lines with
random whitespace changes.

Don't use unadorned "inline", that defines globals.  For inlines in a
header for the kernel, use "static inline".  

For the ia64 register accessors, is it really advantageous to inline those?
Perhaps the functions should be in the runtime proper rather than inlined
by the macros.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]