This is the mail archive of the
systemtap@sources.redhat.com
mailing list for the systemtap project.
Re: [PATCH] kprobes: fix single-step out of line
- From: Paul Mackerras <paulus at samba dot org>
- To: ananth at in dot ibm dot com
- Cc: linuxppc64-dev at ozlabs dot org, anton at samba dot org, systemtap at sources dot redhat dot com
- Date: Fri, 10 Jun 2005 11:41:30 +1000
- Subject: Re: [PATCH] kprobes: fix single-step out of line
- References: <20050525170159.GA9364@in.ibm.com>
Ananth N Mavinakayanahalli writes:
> On Power4 and above, single-step out of line when the instruction copy
> is on a kmalloc'ed memory area, fails with an Instruction Access
> exception. Here is a patch that fixes it.
> +static kprobe_opcode_t stepped_insn;
Hmmm... you are putting the instruction in a location in the data
segment, which may not be mapped executable. You would get away with
it if the kernel is mapped with large pages (which is the default) and
the kernel text + data fits into 16MB (which I hope would be the
case). But still, it's not a really clean solution. However, I'm not
sure what would be better; you need some storage that is both writable
and executable, which we try to avoid having.
Paul.